Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EuiCommentList #3344

Merged
merged 12 commits into from
Apr 21, 2020
Merged

Add EuiCommentList #3344

merged 12 commits into from
Apr 21, 2020

Conversation

andreadelrio
Copy link
Contributor

Summary

  • Created EuiCommentList component
  • Updated folder name in src to go from comment to comment_list. This to follow what we have for similar components (i.e. EuiDescriptionList and EuiListGroup)
  • Updated doc's page so that all the EuiComment examples live under EuiCommentList

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3344/

cchaos
cchaos suggested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the simplified example for just EuiComment, and that the complex one now is for the whole EuiCommentList. I just had a comment around the children vs EuiComment display.

src-docs/src/views/comment/comment_example.js Outdated
/>`;

export const CommentListExample = {
title: 'Comment List',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'Comment List',
title: 'Comment list',

src/components/comment_list/comment_list.tsx Show resolved Hide resolved
src/components/comment_list/comment_list.tsx Outdated Show resolved Hide resolved
src/components/comment_list/index.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3344/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3344/

thompsongl
thompsongl approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and docs updates LGTM!

cchaos
cchaos approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great to me!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3344/

@andreadelrio andreadelrio merged commit 8d789d7 into elastic:master Apr 21, 2020
@thompsongl thompsongl mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreadelrio @kibanamachine @cchaos @thompsongl