EuiHeader Padding & EuiDescribedFormGroup Shrinking Bugs #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMarcialis
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3369/ |
cchaos
reviewed
Apr 22, 2020
src/components/form/described_form_group/_described_form_group.scss
Outdated
Show resolved
Hide resolved
snide
reviewed
Apr 22, 2020
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3369/ |
cchaos
approved these changes
Apr 22, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3369/ |
|
Thanks for the quick fix @MichaelMarcialis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR address two bugs discovered by @myasonik while implementing the new navigation in Kibana. These bug fixes include:
Removal of extra padding that was applied to the
bodyelement whenEuiHeaderis fixed. The extra padding was causing issues with the Maps app, as it is usingcalcto find the remaining screen real estate (minus the header height), in order to show the map in that remaining space.Corrected a bug that was causing
EuiDescribedFormGroupto not shrink down properly as the browser viewport is reduced.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes