Fixed EuiNavDrawer not closing on outside click after being unlocked #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3415/ |
thompsongl
suggested changes
May 4, 2020
|
jenkins test this |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3415/ |
|
jenkins test this #3403 failure |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3415/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3414
Summary
If locked, the old behaviour disabled the outside click detector, even if it was then unlocked again. Even when locked, it seems like the outside click detector doesn't need to be disabled, because it calls closeBoth which also checks if the nav drawer is locked itself, and only closes the outer menu if locked.
This PR adjusts that behaviour so that when the lock button is pressed, the outside click detector is always kept enabled.
Checklist
Props have proper autodocsAdded documentation examplesChecked for accessibility including keyboard-only and screenreader modesGoing to be honest, I'm not really sure how to approach testing this one - happy of course for you guys to just take this change and add tests how you see fit if that's okay?