Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBasicTable] Move to next-to-last page if all items of last pages are deleted. #3431

Merged
merged 8 commits into from
May 18, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented May 6, 2020

Summary

Fixes #3422

Before
Before

After

Screen Cast 2020-05-07 at 1 50 57 AM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myasonik
Copy link
Contributor

myasonik commented May 6, 2020

Just for docs accessibility, when the delete button disappears can we place the user's focus somewhere on the page? The checkbox in the table header is a good option.

@ashikmeerankutty
Copy link
Contributor Author

@myasonik Thanks for the suggestion. I will move the focus to the checkbox in the table header.

@ashikmeerankutty
Copy link
Contributor Author

Just for docs accessibility, when the delete button disappears can we place the user's focus somewhere on the page? The checkbox in the table header is a good option.

@myasonik I can't find a method to do that without modifying the EuiBasicTable Component. Do you have any suggestions?

@myasonik
Copy link
Contributor

Bleeeh, I forgot that forwarding refs is kind of a whole thing...

I've got a PR that I'm hoping to get back to soon that deals with some similar issues for navigation so I can tackle it then.

Feel free to skip this.

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3431/

src/components/basic_table/basic_table.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall Thank you for the review. Changes committed 👍

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested the selection example for basic & in-memory tables and they both work as expected. Will merge on green CI

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3431/

@chandlerprall chandlerprall merged commit d2d3ca2 into elastic:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiBasicTable] shows no items if all items of last page is deleted
5 participants