-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any character to be used in Query #3432
Allow any character to be used in Query #3432
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3432/ |
This is going to be so awesome. ES UI tables break whenever |
@chandlerprall is there anything I can do to help get this over the line? |
3a20cfa
to
2a4d538
Compare
@naderhen thanks for the reminder :) I was out last week, but am back to working on this. Just pushed a refactor of the change to maintain backwards compatibility, better parsing, and correct pretty value printing of these values. Also added a unit test. Remainder of work is to validate the generated ES query string & DSL is correct. I should have this in a completed state soon. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3432/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Preview documentation changes for this PR: https://eui.elastic.co/pr_3432/ |
1 similar comment
Preview documentation changes for this PR: https://eui.elastic.co/pr_3432/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will this fix be available soon? |
This was included in the v26.2.0 release. |
Summary
Closes #2325 and closes #3426
"
and\
characters must be escaped with a backslash"
or\
is present"
and\
charactersChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes