Remove Framer and deprecate EuiNavDrawer family of components #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
commented
May 15, 2020
| @@ -7,6 +7,6 @@ types | |||
| eui.d.ts | |||
| **/*.snap.js | |||
| **/assets/**/*.js | |||
| package.json | |||
There was a problem hiding this comment.
@chandlerprall Need to figure out the a better way to ignore the license header for this file, but keep the rest of the linting intact.
snide
commented
May 15, 2020
Comment on lines
+10
to
+12
| **Notes** | ||
|
|
||
| - Removed `src-framer` files from the repository ([#3487](https://github.com/elastic/eui/pull/3487)) |
There was a problem hiding this comment.
Not really a breaking change, but not a deprecation. Felt this needed to be marked if one day we want to revisit.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3487/ |
thompsongl
reviewed
May 15, 2020
thompsongl
approved these changes
May 15, 2020
|
Checked with @thompsongl and @cchaos. Gonna merge this one on green. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3487/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes our Framer files, which are way out of date and currently unusable in Framer (and have been for nearly a year). Also adds a deprecation warning in
EuiNavDrawer.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes