Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperSelect] Dropdown renders full width when isOpen is true #3495

Merged
merged 3 commits into from
May 18, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented May 16, 2020

Summary

Fixes #3491

Used componentDidMount to render Open animation if Panel is open by default

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17 anishagg17 changed the title Full width [EuiSuperSelect] Dropdown renders full width when isOpen is true May 16, 2020
@miukimiu
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3495/

Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anishagg17. I tested locally and it works properly.

LGTM! 🎉

@miukimiu miukimiu merged commit 104deec into elastic:master May 18, 2020
@anishagg17 anishagg17 deleted the fullWidth branch May 18, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiSuperSelect] Dropdown doesn't render full width when isOpen is true
3 participants