-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added display prop to EuiDataGridColumnSortingDraggable #3574
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3574/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3574/ |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; Tested in the PR's deploy. Will merge when CI passes
Preview documentation changes for this PR: https://eui.elastic.co/pr_3574/ |
Summary
From: #3520 (comment)
Added display prop to
EuiDataGridColumnSortingDraggable
to set the value to the column sorting popover popoverChecklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests