[EuiInMemoryTable] Avoid blocking update for getDerivedStateFromProps #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Thanks for this, @shrey Please update the Summary to describe your proposed solution, and strike-through any Checklist items that are not relevant to this PR. |
thompsongl
changed the title
|
@thompsongl Done |
thompsongl
suggested changes
Jun 9, 2020
|
@thompsongl Made the changes |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3579/ |
|
@thompsongl I don't think any documentation changes will be needed, any other changes? |
Still needs a changelog entry, but I think it's ready otherwise |
|
@thompsongl Now, I think we're good to go :) |
thompsongl
approved these changes
Jun 10, 2020
phyolim
pushed a commit
to phyolim/eui
that referenced
this pull request
Jun 11, 2020
…elastic#3579) * added single return source in getDerivedStateFromProps * implemented changes * Updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Edited the return statement of EuiInMemoryTable's getDerivedStateFromProps in order to return the updated props only once so that all changes get reflected
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modesCloses #3478
@thompsongl @chandlerprall