[EuiForm] Added invalidCallout prop to allow conditional rendering of error callout

[shrey]

Summary

Added an additional boolean showCallout property in EuiForm which the user can set to true if they want the error callout to be shown

Checklist

• Check against all themes for compatibility in both light and dark modes
• Checked in mobile
• Checked in IE11 and Firefox
• Props have proper autodocs
• Added documentation
• Checked Code Sandbox works for the any docs examples
• Added or updated jest tests
• [ ] Checked for breaking changes and labeled appropriately
• [ ] Checked for accessibility including keyboard-only and screenreader modes
• A changelog entry exists and is marked appropriately

Fixes #478 @snide @cchaos

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cchaos]

We try to limit our usage of boolean prop types because they're not scalable.

You'll also need to:

• Add a test for the new prop
• Update the snapshots
• Add a changelog entry

[shrey]

@cchaos Made the changes :)

[shrey]

We try to limit our usage of boolean prop types because they're not scalable.

You'll also need to:

• Add a test for the new prop
• Update the snapshots
• Add a changelog entry

Okay on it

[shrey]

@cchaos Added testing and updated the changelog could you review this?

[chandlerprall]

jenkins test this

[cchaos]

Can you update the PR description to align with the new prop name? We'll also want to add a quick mention of this prop in the docs example. Can you change the example text to:

[shrey]

@cchaos Made the changes, Could you review it?

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3585/

[cchaos]

@shrey You're still missing a few changes from the review like changing the text of the test and docs example.

[shrey]

@cchaos Done

[cchaos]

You'll need to update the snapshots again as well.

[shrey]

@cchaos Updated the snapshot, Could you review it?

[chandlerprall]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3585/

[shrey]

@cchaos Any clue why the tests failed?

[chandlerprall]

15:30:23 Snapshot Summary
15:30:23 › 1 snapshot obsolete from 1 test suite. To remove it, run yarn run test-unit -u.
15:30:23 ↳ src/components/form/form.test.tsx
15:30:23 • EuiForm checks if invalidCallout works 1

Please run yarn test-unit -u to update the snapshot, then add & commit the changes.

[shrey]

@chandlerprall Yeah, done.

[chandlerprall]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3585/

[chandlerprall]

17:45:33 error An unexpected error occurred: "https://registry.yarnpkg.com/nodegit/-/nodegit-0.23.0.tgz: unexpected end of file".

Network error preparing the docker test environment.

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3585/

[shrey]

@chandlerprall passed, finally :)

[cchaos]

Sorry @shrey I messed up the props doc syntax and so the props table wasn't showing the prop comment. I have fixed this now and once CI passes (again) I'll merge it down.

Thanks 🎉 !

[cchaos]

Jenkins, test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3585/

[shrey]

@cchaos No issues, Tests passed :)

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3585/