[EuiHeader] Fix SASS globals & docs #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2020 15:25
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3592/ |
snide
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
This works. I can't wait till we have emotion and can potentially apply a global style when an individual component is used. Would come in really handy here.
I think this quirk of the header is important enough I'd include a note in https://github.com/elastic/eui/blob/master/wiki/consuming.md
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3592/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3589
It was pointed out that the mixin provided for fixed headers wasn't properly importing the necessary variables so consumers got hit with a missing variable error when trying to use it. This was because the header variable that was being used in the mixin wasn't in the global_styles but in the component styles.
I've moved all the header variables to
global_variablessince these seem to be affecting more than itself anyway.I have tested that this fixes the missing variable issue by linking locally in the K8 POC. Errors are gone 👍 !
This also fixes the docs that accidentally said to use
@mixin ...instead of@include ....Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes