Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBasicTable] Custom actions in a collapsed actions menu should close popover on click #3619

Merged
merged 2 commits into from
Jun 16, 2020
Merged

[EuiBasicTable] Custom actions in a collapsed actions menu should close popover on click #3619

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e46aa54
custom actions in collapsed actions menu close popover on click
thompsongl Jun 16, 2020
e34d8a8
CL
thompsongl Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/components/basic_table/collapsed_item_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,12 @@ export class CollapsedItemActions<T> extends Component<
controls.push(
<EuiContextMenuItem
key={key}
onClick={
actionControlOnClick
? actionControlOnClick.bind(null, item)
: () => {}
onClick={() =>
this.onClickItem(
actionControlOnClick
? () => actionControlOnClick(item)
: undefined
)
}>
{actionControl}
</EuiContextMenuItem>
Expand Down Expand Up @@ -159,10 +161,9 @@ export class CollapsedItemActions<T> extends Component<
target={target}
icon={icon}
data-test-subj={dataTestSubj}
onClick={this.onClickItem.bind(
null,
onClick ? onClick.bind(null, item) : undefined
)}>
onClick={() =>
this.onClickItem(onClick ? () => onClick(item) : undefined)
}>
{name}
</EuiContextMenuItem>
);
Expand Down