Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSelectable] Adding more keyboard shortcuts and screen reader instructions #3620

Merged
merged 2 commits into from
Jun 18, 2020
Merged

[EuiSelectable] Adding more keyboard shortcuts and screen reader instructions #3620

merged 2 commits into from
Jun 18, 2020

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented Jun 16, 2020 •
edited
Loading

Summary

  1. Adds a couple more keyboard shortcuts
    • Home to go to top of the list
    • End to go to the end of the list
    • Space as an alias for Enter
  2. Adds some instructions to the exclusion states

Checklist

  • Updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes

@myasonik myasonik changed the title adding more keyboard shortcuts and instructions [EuiSelectable] Adding more keyboard shortcuts and screen reader instructions Jun 16, 2020
@chandlerprall
Copy link
Contributor

jenkins test this

@chandlerprall
Copy link
Contributor

Build error:

16:52:20 Token euiSelectableListItem.includedOptionInstructions has two differing defaults:
16:52:20 To deselect this option, press enter or space.
16:52:20 To exclude this option, press enter or space.

@chandlerprall
Copy link
Contributor

Universe does not like you today. Both CI steps failed with different network-related issues.

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3620/

chandlerprall
chandlerprall approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested in the published docs

@myasonik myasonik merged commit a6ba2b5 into elastic:feature/selectable-a11y Jun 18, 2020
@myasonik myasonik deleted the selectable-a11y/exclusion branch June 18, 2020 19:29
@myasonik myasonik mentioned this pull request Jun 18, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myasonik @chandlerprall @kibanamachine