Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFocusTrap] Use react-focus-on #3631

Merged
merged 20 commits into from
Jul 16, 2020
+338 −2,336
Merged

[EuiFocusTrap] Use react-focus-on #3631

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
361934d
WIP: react-focus-on
thompsongl Jun 17, 2020
319ac9c
WIP: fix GuideFullScreen
thompsongl Jun 17, 2020
e2e1154
Merge branch 'master' into focus-on
thompsongl Jun 18, 2020
53ff16f
Merge branch 'master' into focus-on
thompsongl Jul 6, 2020
72af3a4
noIsolation; onClickOutside
thompsongl Jul 6, 2020
d6f538b
euiflyout snapshot updates
thompsongl Jul 6, 2020
ea48454
euiflyout snapshot updates
thompsongl Jul 6, 2020
d6e02ea
euimodal snapshot updates
thompsongl Jul 6, 2020
3aef4fd
euidatagrid snapshot updates
thompsongl Jul 6, 2020
22b84a3
euicolorpalettepicker snapshot updates
thompsongl Jul 6, 2020
c55dcea
euisuperselect snapshot updates
thompsongl Jul 6, 2020
b20c79d
euicollapsible snapshot updates
thompsongl Jul 6, 2020
c750d0e
euifocustrap snapshot updates
thompsongl Jul 6, 2020
98a2fad
allow for array snapshots with takeMountedSnapshot
thompsongl Jul 6, 2020
29fbba9
docs improvements
thompsongl Jul 7, 2020
85989e3
Merge branch 'master' into focus-on
thompsongl Jul 7, 2020
dcc7db3
Merge branch 'master' into focus-on
thompsongl Jul 14, 2020
26bc04c
default to noIsolation=true and scrollLock=false
thompsongl Jul 14, 2020
cfca928
Merge branch 'master' into focus-on
thompsongl Jul 14, 2020
6b83b20
CL
thompsongl Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
euiflyout snapshot updates
@thompsongl
thompsongl committed Jul 6, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit d6f538b8c125eb0a06c24c7f017d57324258f4fb
86 changes: 43 additions & 43 deletions src/components/flyout/__snapshots__/flyout.test.tsx.snap
View file
Original file line number Diff line number Diff line change
@@ -4,12 +4,12 @@ exports[`EuiFlyout is rendered 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -38,7 +38,7 @@ exports[`EuiFlyout is rendered 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -48,12 +48,12 @@ exports[`EuiFlyout props accepts div props 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -81,7 +81,7 @@ exports[`EuiFlyout props accepts div props 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -91,12 +91,12 @@ exports[`EuiFlyout props close button is not rendered 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -110,7 +110,7 @@ exports[`EuiFlyout props close button is not rendered 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -120,12 +120,12 @@ exports[`EuiFlyout props max width can be set to a custom number 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -134,7 +134,7 @@ exports[`EuiFlyout props max width can be set to a custom number 1`] = `
<div
class="euiFlyout euiFlyout--medium"
role="dialog"
style="max-width:1024px"
style="max-width: 1024px;"
tabindex="0"
>
<button
@@ -153,7 +153,7 @@ exports[`EuiFlyout props max width can be set to a custom number 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -163,12 +163,12 @@ exports[`EuiFlyout props max width can be set to a custom value and measurement
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -177,7 +177,7 @@ exports[`EuiFlyout props max width can be set to a custom value and measurement
<div
class="euiFlyout euiFlyout--medium"
role="dialog"
style="max-width:24rem"
style="max-width: 24rem;"
tabindex="0"
>
<button
@@ -196,7 +196,7 @@ exports[`EuiFlyout props max width can be set to a custom value and measurement
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -206,12 +206,12 @@ exports[`EuiFlyout props max width can be set to a default 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -238,24 +238,24 @@ exports[`EuiFlyout props max width can be set to a default 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
`;

exports[`EuiFlyout props ownFocus can alter mask props with maskProps without throwing error 1`] = `
Array [
<div />,
<main>
<div />
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -282,25 +282,25 @@ Array [
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>,
]
</div>
</main>
`;

exports[`EuiFlyout props ownFocus is rendered 1`] = `
Array [
<div />,
<main>
<div />
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -327,23 +327,23 @@ Array [
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>,
]
</div>
</main>
`;

exports[`EuiFlyout props size l is rendered 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -370,7 +370,7 @@ exports[`EuiFlyout props size l is rendered 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -380,12 +380,12 @@ exports[`EuiFlyout props size m is rendered 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -412,7 +412,7 @@ exports[`EuiFlyout props size m is rendered 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
@@ -422,12 +422,12 @@ exports[`EuiFlyout props size s is rendered 1`] = `
<div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
@@ -454,7 +454,7 @@ exports[`EuiFlyout props size s is rendered 1`] = `
</div>
<div
data-focus-guard="true"
style="width:1px;height:0px;padding:0;overflow:hidden;position:fixed;top:1px;left:1px"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
Loading