-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiCode] and [EuiCodeBlock] updated the props #3647
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@cchaos Done :) |
@thompsongl @cchaos Updated the exporting |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3647/ |
@shrey Does the pre-commit hook script run for you? Both the prettier error and the import/export error from earlier should have been caught by the script that runs before allowing a commit. |
No actually I used `git commit -m "" -n" to commit the changes, I thought that an error wouldn't occur and also because the normal commit take a lot of time, although I'll use from now on. The tests failed though :/ Should I make any changes @thompsongl |
|
@thompsongl Done :) |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3647/ |
@thompsongl Tests passed :) |
Summary
Transferred the
EuiCode
props toEuiCodeBlock
if they weren't being used inEuiCode
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes@thompsongl @snide There's some date error, which I didn't cause when I ran yarn test.
Closes #3612