Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCode] and [EuiCodeBlock] updated the props #3647

Merged
merged 7 commits into from
Jun 25, 2020

Conversation

shrey
Copy link
Contributor

@shrey shrey commented Jun 23, 2020

Summary

Transferred the EuiCode props to EuiCodeBlock if they weren't being used in EuiCode

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl @snide There's some date error, which I didn't cause when I ran yarn test.
Closes #3612
Screenshot 2020-06-23 at 11 39 37 PM

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@shrey
Copy link
Contributor Author

shrey commented Jun 23, 2020

@cchaos Done :)

@shrey
Copy link
Contributor Author

shrey commented Jun 23, 2020

@thompsongl @cchaos Updated the exporting

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3647/

@thompsongl
Copy link
Contributor

@shrey Does the pre-commit hook script run for you? Both the prettier error and the import/export error from earlier should have been caught by the script that runs before allowing a commit.
If you use a GUI for git things (like Tower or Sourcetree) and it isn't running, let me know.

@shrey
Copy link
Contributor Author

shrey commented Jun 24, 2020

@shrey Does the pre-commit hook script run for you? Both the prettier error and the import/export error from earlier should have been caught by the script that runs before allowing a commit.
If you use a GUI for git things (like Tower or Sourcetree) and it isn't running, let me know.

No actually I used `git commit -m "" -n" to commit the changes, I thought that an error wouldn't occur and also because the normal commit take a lot of time, although I'll use from now on. The tests failed though :/ Should I make any changes @thompsongl

@thompsongl
Copy link
Contributor

thompsongl commented Jun 24, 2020

Should I make any changes

yarn lint-fix should get the error fixed. And when you commit after that, the pre-commit hook will make sure there are no other errors.

@shrey
Copy link
Contributor Author

shrey commented Jun 24, 2020

@thompsongl Done :)

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3647/

@shrey
Copy link
Contributor Author

shrey commented Jun 25, 2020

@thompsongl Tests passed :)

@thompsongl thompsongl merged commit 190a43e into elastic:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EuiCode TS interface to reflect used/unused props
4 participants