-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button and toast guidelines #371
Conversation
There are some really great points in here, I think a few could use a bit of a better description to understand the do/don't of it. In terms of designing the page, we should figure out how we want to handle screenshots generally. I also wonder if it would help to add a TOC (or just sub sections on the left sidebar). For the labels section, I would stick to always showing them in button form or not at all (I prefer the former option) and then maybe adding a second column for Good/bad with green/red icons to better discern between good/bad. |
45725bf
to
1d7618f
Compare
OK. I cleaned this one up pretty heavily. For now I'm gonna hide toast and modal guidelines from the side nav till they can get the same treatment, but at this point I'd consider it mergeable minus some copyediting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked through this stuff with gail over a couple sessions. This is good to go.
3e88b85
to
aeb49d7
Compare
Adds the following:
GuideRuleExample
offrame
which will add some styling for siloed content.TODO