Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button and toast guidelines #371

Merged
merged 12 commits into from
Mar 9, 2018
Merged

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Feb 6, 2018

Adds the following:

  • Guidelines for buttons.
  • New prop for GuideRuleExample of frame which will add some styling for siloed content.
  • Adds ability to hide routes from the sidenav. I (Dave) was using something like this for a sandbox earlier, but figured its useful here for the toasts / modal docs were are ok to publish, but still need some cleaning before I'd want them public. Having them in master though means we can point to them and talk about them more easily as a team.

TODO

  • @gchaps needs to copyedit the buttons guideline.
  • Dave needs to clean up the other guidelines (in another PR).

@cchaos
Copy link
Contributor

cchaos commented Feb 8, 2018

There are some really great points in here, I think a few could use a bit of a better description to understand the do/don't of it.

In terms of designing the page, we should figure out how we want to handle screenshots generally. I also wonder if it would help to add a TOC (or just sub sections on the left sidebar).

For the labels section, I would stick to always showing them in button form or not at all (I prefer the former option) and then maybe adding a second column for Good/bad with green/red icons to better discern between good/bad.

@snide
Copy link
Contributor

snide commented Feb 24, 2018

OK. I cleaned this one up pretty heavily. For now I'm gonna hide toast and modal guidelines from the side nav till they can get the same treatment, but at this point I'd consider it mergeable minus some copyediting.

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked through this stuff with gail over a couple sessions. This is good to go.

@snide snide changed the title Button guidelines Button and toast guidelines Mar 8, 2018
@snide snide added documentation Issues or PRs that only affect documentation - will not need changelog entries and removed work in progress labels Mar 8, 2018
@snide snide merged commit 92fb469 into elastic:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants