Build-specific babel config files #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3911/ |
Each of those is 🚀 |
thompsongl
commented
Aug 14, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3911/ |
chandlerprall
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Changes LGTM
- ran all unit tests
yarn build& spot checked output, confirmed removal of docgen entries (esdir went from 8.1MB->5.9MB, 2.2MB reduction)- packed the local build & tested it installed in a CRA app
- confirmed docgen info is still present & rendered in docs (dev server & docs build)
We should look into tightening the browsers env target to get more modern support like const/let in the output, but that's not blocking for this.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3911/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3911/ |
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3801 by reducing the scope of the root
.babelrc.jsfile and creating:scripts/jest/.babelrc.jsby extension of root config; no longer does full browser transformssrc-docs/.babelrc.jsby modification of root config; now the only build that runs react-docgen-typescriptAdditional changes:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes