Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to EuiSearchField if isClearable is true #3936

Merged
merged 5 commits into from
Aug 27, 2020
Merged

Add padding to EuiSearchField if isClearable is true #3936

merged 5 commits into from
Aug 27, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Aug 18, 2020 •
edited
Loading

Summary

Fixes #3882

Before

image

After

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari,
  • Checked in Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ashikmeerankutty ashikmeerankutty changed the title Search field fix Add padding to EuiSearchField if isClearable is true Aug 18, 2020
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3936/

andreadelrio
andreadelrio approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one tiny suggestion for the CL entry. Sorry for the delay reviewing this, I somehow missed the request.

CHANGELOG.md Outdated Show resolved Hide resolved
@ashikmeerankutty @andreadelrio
Update CHANGELOG.md
df691dc 
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3936/

@thompsongl thompsongl merged commit 28d6371 into elastic:master Aug 27, 2020
@myasonik myasonik mentioned this pull request Sep 16, 2020
Closed
7 tasks
chandlerprall added a commit that referenced this pull request Sep 17, 2020
@chandlerprall
Fix changelog entry for #3936
8dcdabd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadelrio andreadelrio andreadelrio approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiFieldSearch's clear button covers the value of the input
4 participants
@ashikmeerankutty @kibanamachine @thompsongl @andreadelrio