-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Sort props in docs in ascending order #3944
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3944/ |
I have a suggestion for this. Lots of times we are writing the props in the component so that they're in an order where they relate to each other. For instance it's nice to keep Is it possible, then to just hook up the sort ability of the table header to allow users to then sort it themselves into the alphabetical order? |
Yes, For that I needed to add the props to the state so that I can update. I have done the changes, Can you please review it. |
retest |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3944/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3944/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM; My only remark is that sorting in descending order isn't present, but I don't know how necessary that is, thoughts @cchaos ?
Playing with the current implementation it feels odd to me to not allow descending order. |
👍 @ashikmeerankutty let's toggle asc->desc->off, then this will be good to go! |
@chandlerprall Updated with asc->desc>off. Can you please review 😃 |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3944/ |
off->asc->desc->off works, re-kicking CI for a flaky unit test - jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3944/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Summary
Makes progress on #3056
Checklist
- [ ] A changelog entry exists and is marked appropriately