-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref in props tab for froward ref components #3956
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3956/ |
This looks good, but is breaking the Props tab for EuiMarkdownEditor - presumably because the editor's ref is a custom value via eui/src/components/markdown_editor/markdown_editor.tsx Lines 285 to 289 in 81f22fe
|
The problem was with |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3956/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; Spot checked existing prop definitions were not affected, but components with forwardRef now include ref
as desired 👍
Summary
Makes progress on #3056
Checklist