Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSR for breadcrumbs and collapsible-nav #3970

Merged
merged 8 commits into from
Sep 2, 2020
Merged

Fix SSR for breadcrumbs and collapsible-nav #3970

merged 8 commits into from
Sep 2, 2020

Commits on Aug 27, 2020

  1. Fix SSR for breadcrumbs and collapsible-nav 

    Closes elastic#3687. Put guards around references to `window` so that in an SSR
environment, EUI will still work.
    @pugnascotia
    pugnascotia committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    6f1dc4a View commit details
    Browse the repository at this point in the history

  2. Use Infinity instead of arbitrary value

    @pugnascotia
    pugnascotia committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ed937b5 View commit details
    Browse the repository at this point in the history

  3. Swap Infinity with -Infinity

    @pugnascotia
    pugnascotia committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b2d934a View commit details
    Browse the repository at this point in the history

  4. Back out unnecessary changes

    @pugnascotia
    pugnascotia committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    5ec527c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge remote-tracking branch 'upstream/master' into fix-breadcrumbs-ssr

    @pugnascotia
    pugnascotia committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    6e0b46d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into fix-breadcrumbs-ssr

    @pugnascotia
    pugnascotia committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    5cea004 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
    @pugnascotia @cchaos
    pugnascotia and cchaos authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b63e4d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Merge branch 'master' into fix-breadcrumbs-ssr

    @pugnascotia
    pugnascotia authored Sep 2, 2020
    Configuration menu
    Copy the full SHA
    86f2bde View commit details
    Browse the repository at this point in the history