Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiKeyPadMenu] Add max-width #4092

Merged
merged 3 commits into from
Oct 1, 2020

Conversation

TAYTS
Copy link
Contributor

@TAYTS TAYTS commented Oct 1, 2020

Summary

Resolves: #4088
Added max-width: 100% in <EuiKeyPadMenu> to allow it to shrink when its container is smaller than the fixed width(288px).

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
    - [ ] Added documentation
  • Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos cchaos changed the title Feature/add max width to keypad menu [EuiKeypadMenu] Add max-width Oct 1, 2020
@cchaos
Copy link
Contributor

cchaos commented Oct 1, 2020

Jenkins, test this

@cchaos cchaos changed the title [EuiKeypadMenu] Add max-width [EuiKeypPadMenu] Add max-width Oct 1, 2020
@cchaos cchaos changed the title [EuiKeypPadMenu] Add max-width [EuiKeyPadMenu] Add max-width Oct 1, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4092/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the quick fix @TAYTS !

@cchaos cchaos merged commit bb0e991 into elastic:master Oct 1, 2020
@TAYTS TAYTS deleted the feature/add-max-width-to-keypad-menu branch October 2, 2020 02:31
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
* Added max-width:100% in EuiKeyPadMenu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiKeyPadMenu] Change declared width to maxWidth
3 participants