Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Add plus and minus glyphs #4111

Merged
merged 6 commits into from
Oct 7, 2020

Conversation

andreadelrio
Copy link
Contributor

Summary

Adds plus and minus glyphs. This PR contains the option where the stroke width is 1px. I also explored the option of 1.5px stroke width as you'll see in the screenshots below (plus1_5 and minus1_5).
image_b
image_a
image_c

Fixes #1748

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
    - [ ] Props have proper autodocs
  • Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [x] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/

@thompsongl
Copy link
Contributor

Just a note that the change to all icon files is a result of upgrading @svgr/core. This just happened to be the first time the icons were recompiled since the upgrade.

@cchaos
Copy link
Contributor

cchaos commented Oct 6, 2020

Honestly, I know it goes against our typical glyph making rules, but the 1.5px stroke makes such a small icon so much easier to see. I even checked it on a non-retina screen, and yes, while it's not as "crisp" as the single pixel, it's still bolder and easier to see.

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @cchaos have final say on the new icons, but the other 400 files changed LGTM 😄

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/

@cchaos
Copy link
Contributor

cchaos commented Oct 6, 2020

Jenkins, test this

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 👍

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/

@andreadelrio andreadelrio merged commit 20beb24 into elastic:master Oct 7, 2020
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon] A bare plus sign icon would be desirable
4 participants