Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the way EuiCard inherits EuiPanel #415

Merged
merged 7 commits into from
Feb 16, 2018
Merged

Changing the way EuiCard inherits EuiPanel #415

merged 7 commits into from
Feb 16, 2018

Commits on Feb 15, 2018

  1. Fixing panel doc

    cchaos committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    efe2fde View commit details
    Browse the repository at this point in the history

  2. Comitting for posterity 

    Having EuiPanel > EuiCard doesn’t work because it still needs `display: flex` on EuiPanel but the order in which the SASS files are loaded doesn’t allow for EuiCard styles to override EuiPanel.
    cchaos committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    d980560 View commit details
    Browse the repository at this point in the history

  3. Revert "Comitting for posterity" 

    This reverts commit d980560.
    cchaos committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    bf602bf View commit details
    Browse the repository at this point in the history

  4. Fixing EuiCard inheritance of EuiPanel 

    EuiPanel now has a mixin that can be used by any component. EuiCard uses this mixin to inherit the styles of EuiPanel but doesn’t have specificity/order issues.
    cchaos committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    9c9cffc View commit details
    Browse the repository at this point in the history

  5. changelog

    cchaos committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ab03ad0 View commit details
    Browse the repository at this point in the history

  6. Better error message

    cchaos committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    11e4690 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Address PR comments 

    Spans always and no universal selector
    cchaos committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    ecdcfd8 View commit details
    Browse the repository at this point in the history