-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs, EuiInMemoryTable] Recreating props tables #4179
[Docs, EuiInMemoryTable] Recreating props tables #4179
Conversation
@thompsongl, when I comment on The props table notes column shows empty: |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4179/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…replace-props-table
Thanks, @thompsongl. Deleting the cache worked. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4179/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to merge master and move the changelog entry, but otherwise LGTM
Noted the follow-up PRs mentioned in the summary
Preview documentation changes for this PR: https://eui.elastic.co/pr_4179/ |
Summary
Closes #4149
The EuiInMemoryTable was using a
props_info.js
file to generate the props table in our docs. With this PR I'm using the new!!prop-loader!
to recreate the EuiInMemoryTable props tables.I'm also deleting the
props_info.js
from the EuiBasicTable that was also being used to generate the EuiInMemoryTable props tables.This PR also closes #3623. Now both EuiBasicTable and EuiInMemoryTable props tables are showing common props like
data-test-subj
andclassName
.We're still having some issues with
export type ...
which shows empty. For this reason, #3381 will be addressed with #4129.Checklist
[ ] Checked in mobile[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes