Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFormControlLayout] Fix prepend/append border radius in Amsterdam #4196

Merged
merged 12 commits into from
Nov 5, 2020

Conversation

andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Oct 29, 2020

Summary

  • Fix border-radius in EuiFormControlLayout in Amsterdam
  • Add mixin to avoid code repetition
  • Consolidated backgrounds to be the same color for all append/prepend items

Before
Image 2020-10-20 at 1 24 49 PM

After
Screen Shot 2020-11-04 at 14 40 27 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/

@cchaos
Copy link
Contributor

cchaos commented Nov 4, 2020

The contrast actually isn't great right now for buttons. But I'll update that in a follow up PR.

@miukimiu Can you take over the review since I was doing some of the updates too.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! 🎉

I looked at the code and tested in Safari, Firefox, Chrome, and Edge.

I just noticed that in Safari 14.0 and Firefox 82.0.2 (64-bit) the border/shadow is not looking 100% perfect.

Screenshot 2020-11-05 at 19 07 08

But it seems that is an old issue that exists in master in all inputs.

Screenshot 2020-11-05 at 19 07 21

The issue is on the box-shadow: 0 0,inset 0 0 0 1px rgba(19,34,149,0.1);. We can open another issue to solve this.

@cchaos
Copy link
Contributor

cchaos commented Nov 5, 2020

Nice eagle eye! Yeah, it's not directly related to this PR. But yeah that 0 0, in the box-shadow is what is causing this. I'll go ahead and try to track down and fix.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/

@cchaos cchaos merged commit ea8c2c2 into elastic:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants