-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiFormControlLayout] Fix prepend/append border radius in Amsterdam #4196
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/ |
Putting the prepend/append background color on the whole group
Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/ |
919f540
to
ccc7c33
Compare
The contrast actually isn't great right now for buttons. But I'll update that in a follow up PR. @miukimiu Can you take over the review since I was doing some of the updates too. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! 🎉
I looked at the code and tested in Safari, Firefox, Chrome, and Edge.
I just noticed that in Safari 14.0 and Firefox 82.0.2 (64-bit) the border/shadow is not looking 100% perfect.
But it seems that is an old issue that exists in master in all inputs.
The issue is on the box-shadow: 0 0,inset 0 0 0 1px rgba(19,34,149,0.1);
. We can open another issue to solve this.
Nice eagle eye! Yeah, it's not directly related to this PR. But yeah that |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4196/ |
Summary
EuiFormControlLayout
in AmsterdamBefore
After
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes