-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiComment] Remove shadow in Amsterdam #4321
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for making that change.
One thing I noticed when I was comparing to the default theme is that maybe the current box-shadow is a bit too deep for a list of comments.
What do you think about switching it to use the slight
version of the drop-shadow to better match with EuiPanel?
Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/ |
@cchaos I think that's a good idea! I made the change, I'll merge on green. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/ |
Summary
EuiComment
in Amsterdam for consistency.Checklist
- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes