Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComment] Remove shadow in Amsterdam #4321

Merged
merged 7 commits into from
Dec 2, 2020

Conversation

andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Nov 30, 2020

Summary

  • Removed shadow from EuiComment in Amsterdam for consistency.

Frame 3

  • Reduce shadow in the default theme.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/

@andreadelrio andreadelrio changed the title [EuiComment] Remove border in Amsterdam [EuiComment] Remove shadow in Amsterdam Dec 1, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for making that change.

One thing I noticed when I was comparing to the default theme is that maybe the current box-shadow is a bit too deep for a list of comments.

Screen Shot 2020-12-01 at 13 40 49 PM

What do you think about switching it to use the slight version of the drop-shadow to better match with EuiPanel?

Screen Shot 2020-12-01 at 13 39 01 PM

CHANGELOG.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/

@andreadelrio
Copy link
Contributor Author

Looks great to me! Thanks for making that change.

One thing I noticed when I was comparing to the default theme is that maybe the current box-shadow is a bit too deep for a list of comments.

Screen Shot 2020-12-01 at 13 40 49 PM

What do you think about switching it to use the slight version of the drop-shadow to better match with EuiPanel?

Screen Shot 2020-12-01 at 13 39 01 PM

@cchaos I think that's a good idea! I made the change, I'll merge on green.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4321/

@andreadelrio andreadelrio merged commit 7846654 into elastic:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants