Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side nav items only behave clickable if they are #434

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Side nav items only behave clickable if they are #434

merged 2 commits into from
Feb 23, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 22, 2018 •
edited
Loading

Fixes #433

screen capture on 2018-02-21 at 19-00-29

@cchaos cchaos requested a review from snide February 22, 2018 00:02
snide
snide approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once it passes.

@snide
Copy link
Contributor

snide commented Feb 23, 2018

jenkins test this

@cchaos cchaos merged commit 06bd42c into elastic:master Feb 23, 2018
@cchaos cchaos deleted the 433-side-nav-item branch February 23, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @snide