-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSuperDatePicker]Changed to EuiFlexGrid
view in Recently used date ranges
#4370
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you the PR! Looks great! I see just two small edits we still need to make.
src/components/date_picker/super_date_picker/quick_select_popover/recently_used.tsx
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/recently_used.tsx
Outdated
Show resolved
Hide resolved
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4370/ |
src/components/date_picker/super_date_picker/quick_select_popover/recently_used.tsx
Outdated
Show resolved
Hide resolved
Hey @Dishebh , it looks like CI is failing because of formatting issues here too. I'd suggest installing a prettier formatter that will format on save for you. Or you'll need to be sure to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually don't want the recently used to be two columns like the commonly used because these can usually be pretty long if the user has selected absolute dates.
Therefore, we can just use the <ul>
and <li>
elements directly instead of EuiFlexGrid. Also we seem to have a sizing issue because of the removal of EuiText.
Let me know if you need help with any of that.
|
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4370/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The a11y changes look good to me! Thanks for making this change @Dishebh!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for getting this one started @Dishebh . I pushed a final commit just to fix up some class naming and added a Changelog. The CI build has passed so we're all good!
Summary
Fixes #4226
Changed to
EuiFlexGrid
view inRecently used date ranges
underEuiRecentlyUsed
component.Checklist
[x] Props have proper autodocs[x] Added documentation[x] Checked Code Sandbox works for the any docs examples[x] Added or updated jest tests[x] Checked for breaking changes and labeled appropriately