Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperDatePicker]Changed to EuiFlexGrid view in Recently used date ranges #4370

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

Dishebh
Copy link
Contributor

@Dishebh Dishebh commented Dec 9, 2020

Summary

Fixes #4226
Changed to EuiFlexGrid view in Recently used date ranges under EuiRecentlyUsed component.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [x] Props have proper autodocs
  • [x] Added documentation
  • [x] Checked Code Sandbox works for the any docs examples
  • [x] Added or updated jest tests
  • [x] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you the PR! Looks great! I see just two small edits we still need to make.

@cchaos cchaos self-requested a review December 9, 2020 17:33
@cchaos
Copy link
Contributor

cchaos commented Dec 10, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4370/

@cchaos
Copy link
Contributor

cchaos commented Dec 10, 2020

Hey @Dishebh , it looks like CI is failing because of formatting issues here too. I'd suggest installing a prettier formatter that will format on save for you. Or you'll need to be sure to run yarn lint-fix every time. I'd also be sure not to skip any of the pre-commit hooks which will catch these for you before you push.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't want the recently used to be two columns like the commonly used because these can usually be pretty long if the user has selected absolute dates.
Image 2020-12-10 at 1 37 47 PM

Therefore, we can just use the <ul> and <li> elements directly instead of EuiFlexGrid. Also we seem to have a sizing issue because of the removal of EuiText.

Let me know if you need help with any of that.

@cchaos
Copy link
Contributor

cchaos commented Dec 10, 2020

☹️ It looks like something went wrong when updating from master. You might want to rebase and start over...?

@cchaos
Copy link
Contributor

cchaos commented Dec 14, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4370/

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The a11y changes look good to me! Thanks for making this change @Dishebh!

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for getting this one started @Dishebh . I pushed a final commit just to fix up some class naming and added a Changelog. The CI build has passed so we're all good!

@cchaos cchaos merged commit 9571192 into elastic:master Dec 14, 2020
@Dishebh Dishebh deleted the superDate branch December 15, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiSuperDatePicker] "Recently used date ranges" looks like a list but isn't
4 participants