Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve KuiContextMenu keyboard navigation UX #44

Merged
merged 4 commits into from
Oct 27, 2017
Merged

Improve KuiContextMenu keyboard navigation UX #44

merged 4 commits into from
Oct 27, 2017

Commits on Oct 27, 2017

  1. Improve KuiContextMenu keyboard navigation UX 

    * Refactor focus state logic to use the React lifecycle correctly.
* Update KuiPopover snapshots.
* Remove unnecessary isVisible prop from KuiContextMenu.
* Allow user to both tab AND use the arrow keys for navigation.
* Reinstate ability to tab and shift-tab to the title of KuiContextMenuPanel.
* Release focus from Dashboard panel options KuiContextMenu by closing it when you select an option.
* Update KuiContextMenu example to demonstrate best practice of closing the menu when an item is clicked.
* Replace native transitionend event handler with onAnimationEnd React event handler.
    @cjcenizal
    cjcenizal committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    573a9db View commit details
    Browse the repository at this point in the history

  2. Fix tabbing bug and address Dave's feedback.

    @cjcenizal
    cjcenizal committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    5c8d1be View commit details
    Browse the repository at this point in the history

  3. Improve logic for tabbing through a ContextMenuPanel's form elements. 

    - Support left arrow going back when the panel itself is focused.
[UI Framework] Fix Popover and ContextMenu bugs.
* Rename KuiPopover isFocusable prop to ownFocus. Focus on first focusable element by default.
* Fix bug where ContextMenuPanel keyboard navigation broke if the user was using tab instead of arrow keys.
    @cjcenizal
    cjcenizal committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    6ec905a View commit details
    Browse the repository at this point in the history

  4. Move jest dir into scripts dir. Update snapshots and fix test warnings.

    @cjcenizal
    cjcenizal committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    06a4cbc View commit details
    Browse the repository at this point in the history