-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Page Layouts] Adding content props to EuiPageHeader for pre-determined page layout patterns #4451
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
Both comments (somewhat) addressed in cchaos#39 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
prevent format errors
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
This is great! I found the docs needed some clarity around the new components. I primarily wanted the main example to show off the full, common layout that you're driving for. I know this is just a temporary state till you add more to it, but the previous example only told a partial story and with big "family" docs like these, I think it's good to start big and then break down the components as you read. Before it seemed to jump around a bit in the order (first page and header, then page, then header, then back to page). This gave me a moment to get familiar with the new code, which worked really well. Only commentary there is that maybe you might want to label |
Thanks @snide ! I've gone through your PR and did a couple updates before merging as well.
Yes it will. 😉 There's no way for users not to have it be on the right.
I had this thought too but that would conflict with the regular HTML DOM property |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the way you thought about all the props. It makes the EuiPageHeader much more flexible. 🎉
Tested in Chrome, Firefox, Edge, and Safari, and it looks good. I just have a few suggestions.
… what the prop type is
…ops` Also had to change the EuiFlexGroupProps to include ALL props (like Common)
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small TS things and a question
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the CL update 👍
Preview documentation changes for this PR: https://eui.elastic.co/pr_4451/ |
To make it easier for Elastic products to follow the new page layout patterns, this PR adds some content-specific props for passing in things like
pageTitle
, andtabs
. The left side content is the most prescriptive because there really are only a few options for how the titling, description and/or tabs should be handled. However, there's a wide variety of ways our products will utilize the right side of the page header, so I've opted to keep that one less specific.The new docs section explains it best.
This PR doesn't quite handle any Amsterdam specific theming or how the page header interacts with other page components yet. That will be forthcoming.
Also, to note, in order to make the component easier to manage, there is a new component called EuiPageHeaderContent which just handles the display of the content-specific props.
Checklist
[ ] Checked for breaking changes and labeled appropriately