Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make full screen code block use the same font-size on the original code block #447

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Make full screen code block use the same font-size on the original code block #447

merged 1 commit into from
Feb 24, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Feb 23, 2018 •
edited
Loading

The large font size was driving me a little nuts because I kept trying to expand the code block to see more code, but the larger font-size meant I just ended up seeing the same amount of code, only larger!

@cjcenizal cjcenizal requested a review from snide February 23, 2018 22:03
snide
snide approved these changes Feb 24, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not tied to this. I originally used the larger font size to make things more readable for people, but I can see this side of the argument too. If it bugs ya go for it.

@cjcenizal
Copy link
Contributor Author

Thanks

@cjcenizal cjcenizal merged commit df21979 into elastic:master Feb 24, 2018
@cjcenizal cjcenizal deleted the full-screen-code-block-font-size branch February 24, 2018 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @snide