-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Color Palettes] Updated the status color palette sequence #4508
[Color Palettes] Updated the status color palette sequence #4508
Conversation
Updating the status color palette sequence to use the more appropiate positive and negative colors for success and failure indication.
I would definitely need to update https://elastic.github.io/eui/#/display/badge#badge-for-health-status to use the new palette as well for consistency, but maybe in another PR? |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4508/ |
Yeah my original intent with it being slightly different at the few number of steps was to make it not be so harsh/dark. But I didn't take into account the possible inconsistencies. I double checked that this 3 color combo still passes the a11y checks, and it does. 👍 So all that's needed is a Changelog entry.
You could open a separate PR, but since this one is actually so small of a change, you could also add it to this one then take it out of draft mode to signal ready for review. |
Sweet 👍
Done ✅
I think I'd want to clarify the other use case of displaying HTTP status codes using the |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4508/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Though we also did just have a release, so you'll need to update from master and move you CL entry to the top.
Preview documentation changes for this PR: https://eui.elastic.co/pr_4508/ |
Summary
Currently, the steps in the
euiPaletteForStatus
are using the regulareuiColorBlindSafe
steps to indicate green or red status. Updating the status color palette sequence to use the more appropriate positive and negative colors for success and failure indication.Observability will be aligning the HTTP status color codes to use the
euiPaletteForStatus
colors to indicate the various steps, and typically those colors have higher contrast than the existingeuiColorBlindSafe
palette. Essentially, we'll define the HTTP status color based on the palette and thepositiveColor
andnegativeColor
variables.After
APM examples
Metrics examples
Checklist
[ ] Checked in mobile[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/master/wiki/documentation-guidelines.md#adding-playground-toggles)**[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately