Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert grid background color #4542

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Revert grid background color #4542

merged 2 commits into from
Feb 18, 2021

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 18, 2021

Summary

This reverts the background color of the data grid content. Although the light gray works well for loading states, it isn't a good experience for fixed height grids with a low amount of items. We'll solve the loading issue in a better way in 7.13. I'm leaving the scrollbar mixin as is because I think it will be useful in other spots.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@snide snide mentioned this pull request Feb 18, 2021
2 tasks
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@snide snide merged commit 4b5b261 into elastic:master Feb 18, 2021
@snide snide deleted the fix/grid_color branch February 18, 2021 06:33
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4542/

@j-m
Copy link
Contributor

j-m commented Mar 30, 2021

I've finally pulled in grid virtualisation and was surprised to see this removed. I know this likely doesn't meet colour contrast accessibility requirements, but imo this is better than the potentially confusing gap on the last page of a grid

.euiDataGrid__content {
  background: #fdfdfd;
  box-shadow: 0 0 0 1px #f3f3f3 inset;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants