Misc fixes #473
Misc fixes #473
Conversation
CHANGELOG.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| # [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| No public interface changes since `0.0.25`. | |||
| - Don't propagate a null `onClick` on EuiPanels | |||
There was a problem hiding this comment.
Can you add links to this PR in these notes, like in the other notes?
CHANGELOG.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| # [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| No public interface changes since `0.0.25`. | |||
| - Don't propagate a null `onClick` on EuiPanels | |||
| - Use 1.1px for the default horizontal line height, in order to work around | |||
There was a problem hiding this comment.
Can we change "default horizontal line height" to "EuiHorizontalRule height"?
src/components/panel/panel.js
Outdated
| className: classes | ||
| } | ||
|
|
||
| // Avoid passing down this props if is hasn't been supplied, in order to |
There was a problem hiding this comment.
I see a couple typos here: "props" -> "prop" and "is" -> "it"
src/components/panel/panel.js
Outdated
|
|
||
| // Avoid passing down this props if is hasn't been supplied, in order to | ||
| // avoid noise in snapshots. | ||
| if (onClick != null) { |
There was a problem hiding this comment.
I tried checking out master and updating the test for this component to use shallow and mount, in an effort to reproduce the problem we're fixing here. But I wasn't able to generate a snapshot with an onClick printed out. Where are you encountering this issue?
|
@pugnascotia Can someone show me where you're seeing the 1px thing? I'd love to replicate it so I can find the root cause. Setting it to 1.1px seems pretty hacky and I'm sure there's something else at play that's causing it. |
This works around strange Chrome height calculations.
|
@cjcenizal I've made the fixes you pointed out. Re: testing, the issue shows up if you're using @snide I don't have a demo to hand, but I'll be working in that area again soon, so I'll unapply the local fix and see what I can pass to you. |
onClickon EuiPanels. This helps avoid noise in Jest snapshots.