Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Handle initialFocus #4768

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 29, 2021

Summary

Fixes #4767, where it was discovered that EuiPopover would exit early from its method to set initial focus, causing the initialFocus prop to be disregarded.

The fix here is to ensure that focus has been intentionally set, not just that any element has focus.
false is now an option for intialFocus to allow consumers to opt-out of initial auto-focus while maintaining focus trapping.

Wasn't able to write a test that actually worked.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile

- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4768/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Verified the popfirst change works as expected in the form layouts' inline popover example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiPopover] initialFocus disregarded
3 participants