Add ability to specify default page size for EuiInMemoryTable #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
suggested changes
Mar 7, 2018
| @@ -34,6 +34,10 @@ const InMemoryTablePropTypes = { | |||
| PropTypes.bool, | |||
| PropTypes.shape({ | |||
| pageSizeOptions: PropTypes.arrayOf(PropTypes.number) | |||
| }), | |||
| PropTypes.shape({ | |||
| defaultPageSize: PropTypes.number, | |||
There was a problem hiding this comment.
We've been using the term initial in other places to indicate the initial value of a prop which the user can later change. Can we rename this to initialPageSize?
| @@ -54,7 +58,10 @@ const initialCriteria = (props) => { | |||
| return { | |||
| page: !pagination ? undefined : { | |||
| index: 0, | |||
| size: pagination.pageSizeOptions ? pagination.pageSizeOptions[0] : paginationBarDefaults.pageSizeOptions[0] | |||
| size: pagination.pageSizeOptions ? ( | |||
There was a problem hiding this comment.
I was having a hard time parsing these nested ternaries. Can we simplify this a bit, and also throw an error if the user has misconfigured the initial page size?
const initialCriteria = (props) => {
if (!props.pagination) {
return {
page: undefined,
};
}
const {
pagination: {
pageSizeOptions,
initialPageSize,
}
} = props;
if (initialPageSize && !pageSizeOptions.includes(initialPageSize)) {
throw new Error(`EuiInMemoryTable received initialPageSize ${initialPageSize}, which wasn't provided within pageSizeOptions.`);
}
const defaultPageSize = pageSizeOptions ? pageSizeOptions[0] : paginationBarDefaults.pageSizeOptions[0];
return {
page: {
index: 0,
size: initialPageSize || defaultPageSize,
}
};
};
|
Thanks for the feedback @cjcenizal, updated! |
|
Oh and don't forget to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
EuiInMemoryTableuses the first element inpageSizeOptionsas the initial page size. This allows a different initial page size to be specified.