-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiComboBox] autoFocus
behavior
#4772
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4772/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the temporary example (in Chrome only). Have you also tested this behavior in portal content like popover or flyout?
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
I haven't but I will. Popovers, portals, etc. have their own initial focus methods that are more heavy-handed and will likely take precedence. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4772/ |
I was incorrect. |
I think that makes the most sense? |
I agree. Use/mimic the native browser API as much as possible. |
* add autoFocus * revert me * CL * Apply suggestions from code review Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Summary
Adds a top-level
autoFocus
prop that gets passed through to the input, enabling native HTMLautofocus
behavior.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Added documentation