[EuiDataGrid] Remove screen reader text from cell popovers #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5087/ |
cee-chen
approved these changes
Aug 25, 2021
snide
approved these changes
Aug 25, 2021
That's a good point. After stepping away for minute, I think this could work with a Fragment, which would negate the added DOM. I'll try it. |
cchaos
approved these changes
Aug 25, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5087/ |
|
QA still looks great with the Fragment. Really nice catch @snide @thompsongl! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4957 by rearranging elements in a way that excludes screen reader text from the scope of what is provided to the popover render function.
The
Node.innerTextmethod used by the standard json popover (as well as the custom array popover noted in the issue) does not ignore "hidden" content such as that insideEuiScreenReaderOnly. This PR removes the screen reader text from consideration while not requiring apps with custom render functions to update their methods.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples