Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] pass items to BasicTable when message is provided #517

Merged
merged 3 commits into from
Mar 15, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 15, 2018

No description provided.

@nreese nreese requested review from uboness and cjcenizal March 15, 2018 02:49
@uboness
Copy link
Contributor

uboness commented Mar 15, 2018

maybe I'm missing something, but the the items and message are mutually exclusive when it comes to showing content... you can't show both... if you want to show items just provide items, if you want to show a message just provide the message... why would you want to pass both if you're always showing the message if one is provided?

@nreese
Copy link
Contributor Author

nreese commented Mar 15, 2018

The problem is that filtering does not update anything on the consumer. There is no way to know when filtering has reduced the items length to 0 to then be able to set the message property.

For example, lets say you want a custom "not found" message. If you pass items to EuiInMemoryTable there is nothing to hook into to know when filtering has reduced the items list to zero.

BasicTable already has this logic and only displays the message when items is empty.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit d925587 into elastic:master Mar 15, 2018
@snide snide added the bug label Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants