Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EuiPageContent centering #527

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Fix EuiPageContent centering #527

merged 2 commits into from
Mar 16, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Mar 15, 2018

This fixes a very old bug introduced when EuiPanel took on flex abilities based upon if it was placed in a flex item. That change broke a couple instances of positioning in EuiPage, where panels nest inside of flex layouts.

This change sets the grow to 0 for EuiPageCOntent, which itself is an EuiPanel. The specificity is changed so we don't need to resort to !important tags.

Before

image

After

image

@snide snide added the bug label Mar 15, 2018
@snide snide merged commit 12cb5d2 into elastic:master Mar 16, 2018
@snide snide deleted the pagefix branch March 16, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant