Add EuiIconTip #528
Merged
Add EuiIconTip #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
info-tool-tip
branch
from
7b772e0
to
26580d7
Compare
snide
approved these changes
Mar 16, 2018
There was a problem hiding this comment.
Looks good. Do you mind adding to the docs that it accepts / passes down the props to EuiToolTip? Maybe show that in the example... add position="right" to one of them or something.
Might wanna name it EuiIconToolTip just because it's directly related, but I don't care strongly about it if we wanna go with the shorthand.
cjcenizal
force-pushed
the
info-tool-tip
branch
from
b5d4262
to
3115e16
Compare
|
Thanks @snide, good point about the docs. I like the short-hand so I'm going to leave the name as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use them to replace the
kbn-infodirective in Kibana. This is something we need to do before 6.3 because a recent change broke these tooltips: