[EuiDataGrid] Fix grids that set a defaultHeight with lineCount and rowHeights overrides with lineCount
#5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove line overrides from auto example (causes confusion during testing, isn't necessary)
…cache instead of setting the minRowHeight - the lineCount overrides are causing incorrect minRowHeight calculations for other rows, so they need their own specific map, and the auto one is right there 🤷
9 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5376/ |
chandlerprall
suggested changes
Nov 16, 2021
cee-chen
force-pushed
the
datagrid-fix-line-height-overrides
branch
from
45d6824 to
e7c6ed1
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5376/ |
| @@ -218,6 +218,9 @@ describe('EuiDataGridCell', () => { | |||
| }); | |||
|
|
|||
| callMethod(component); | |||
| expect( | |||
| mockRowHeightUtils.calculateHeightForLineCount | |||
| ).toHaveBeenCalledWith(expect.any(HTMLElement), 3, false); | |||
chandlerprall
approved these changes
Nov 16, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5376/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found this bug while QAing my row height switcher work 🐛
Problem
The bug was caused by #5354: the switch to using
minRowHeightstate forlineCountassumed that every single row in the grid would be the same height, and did not account for therowHeightsobject which allows overriding specific rows with customlineCounts, e.g.:The bug results in the before gif you can see below, where multiple rows are all fighting to set different
minRowHeights 😬 (EDIT: The gif actually doesn't have the FPS to capture the extent of the brokenness, there's way more flashing stuff going on if you test the REVERT commit against prod).Solution
The solution I came up with was to bogart the existing
heightsCachethat auto heights use, but for lineCount overrides only. This is probably a little over-engineered for lineCount heights, but since I doubt many consumers are setting customrowHeights.lineCounts, I don't think it'll have a significant performance impact, and from a developer readability standpoint I think it's not adding too much spaghetti (and said spaghetti at least has comments + unit tests added for context).Before
before.mp4
After
after.mp4
Extra
This PR also simplifies the
autoheight example, as that example does not needrowHeightsoverrides and it was always really confusing to me while debugging/testing 🙈Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriatelyLeaving out a changelog as this bug is in