Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify initial sorting to EuiInMemoryTable #547

Merged

Conversation

jen-huang
Copy link
Contributor

Fixes #464

Allows user to specify initial sorting by passing an object to the sorting prop. sorting will still take boolean values. Passing an object will enable sorting (same as using sorting={true}). The object shape is the same as the sorting prop for EuiBasicTable.

@jen-huang jen-huang requested review from uboness and cjcenizal March 20, 2018 20:08
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@jen-huang jen-huang force-pushed the enhance/in-memory-table-initial-sort branch from f8c8da0 to bba493f Compare March 21, 2018 18:07
@jen-huang jen-huang merged commit 769bb30 into elastic:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants