-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update components to support both href and onClick #554
Update components to support both href and onClick #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as advertised and the functionality seems fine. If this is the pattern we're going with can we...
- Update the docs to show a live example.
- Can be a seperate PR, but we should update all the button components to do the same, since right now they operate in the reverse and could probably accept both as well.
Also don't forget a changelog item. |
Ah. I had failed to read the contributing guide for eui. Sorry about that! |
Hm. Button does this slightly differently. Instead of checking if href is undefined, it checks if it's falsy. I don't know which is preferable. Thoughts? |
FYI, hold off on reviewing until my next comment. I'm going to go ahead and make the button changes in this PR, since it makes some cleanup easier. |
I forgot to give the all-clear. This is once again ready for review! |
ac09147
to
06ddb8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snide Thanks! I just took a look at the props. They don't seem to conflict with this change, but agree, in general, they're pretty sparse. I think I'll check this in, though. |
Fixes #553 and Fixes #558