Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Fix open cell popovers causing auto height rows to bug out + misc cleanup #5622

Merged
merged 10 commits into from
Feb 10, 2022
Merged

[EuiDataGrid] Fix open cell popovers causing auto height rows to bug out + misc cleanup #5622

merged 10 commits into from
Feb 10, 2022

Commits on Feb 10, 2022

  1. Fix auto height rows breaking when cell popover opens 

    The `flex` display on the parent `.euiDataGridRowCell` is unnecessary, and what's causing this bug
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    6b587ad View commit details
    Browse the repository at this point in the history

  2. [cleanup] Remove unnecessary position relative on .euiDataGridRowCell 

    - it's being overridden by react-window's absolute positioning in any case
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    7745f89 View commit details
    Browse the repository at this point in the history

  3. [cleanup] Remove unnecessary euiDataGridRowCell__expand class from … 

    …the popover anchor wrapper

- as far as I can tell, it's not doing anything
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    d3deba6 View commit details
    Browse the repository at this point in the history

  4. [cleanup] Focus trap/popover hacks 

    - the width properties aren't doing anything, so remove them

- the height property is doing something but is superfluous with the inline height: 100%, so remove the inline style

- add an overflow hidden to preserve overflowing content being correctly cropped by the cell padding when the popover is open (the EuiWrappingPopover adds extra div wrappers)
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    f207a7e View commit details
    Browse the repository at this point in the history

  5. [misc cleanup] DRY out showCellActions if statement 

    - can be conditional JSX instead of repeating EuiDataGridCellContent again
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    c671dca View commit details
    Browse the repository at this point in the history

  6. Add changelog entry

    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    0cf792c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into datagrid/fix-auto-height-popover-2

    Constance authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2f37a6d View commit details
    Browse the repository at this point in the history

  8. Revert popover cutoff change, it's introducing too many side effects 

    + was already in place in main since 40.0.0
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    384d41e View commit details
    Browse the repository at this point in the history

  9. Fix broken focus cell positioning on footer cells 

    - footer cells aren't virtualized and don't have absolute positioning inline
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    e527ceb View commit details
    Browse the repository at this point in the history

  10. Fix more footer issues 

    + move footer-specific CSS that virtualized data grid cells don't need to the footer row file
    @cee-chen
    cee-chen committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    fd4672f View commit details
    Browse the repository at this point in the history