Adjust hue for warning callouts specifically #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this |
cchaos
approved these changes
Mar 22, 2018
src/themes/eui/eui_colors_dark.scss
Outdated
| @@ -8,6 +8,8 @@ $euiColorDarkShade: #D9D9D9; | |||
| $euiColorDarkestShade: #F5F5F5; | |||
| $euiColorFullShade: #FFF; | |||
| $euiColorPrimary: #4da1c0; | |||
| $euiColorPrimary: #4da1c0; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current warning color works in most places, but with lighter shading like callouts it gets too close to the red. This adjusts the hue for that specific section (and we might do something like this in other places as we need it). Screenshot to show that accessibility is still valid.
I'd rather do a math coloring than make a new variable because it gets easy to over tokenize stuff.
cc @timroes, @alexfrancoeur