Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EuiToolTip mouseout logic. #564

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Fix EuiToolTip mouseout logic. #564

merged 2 commits into from
Mar 22, 2018

Conversation

cjcenizal
Copy link
Contributor

No description provided.

@cjcenizal cjcenizal requested a review from snide March 22, 2018 17:17
@cjcenizal cjcenizal force-pushed the bug/tooltip-anchor-mouse-out branch 3 times, most recently from dda04d4 to 0b3ca51 Compare March 22, 2018 17:26
@cjcenizal cjcenizal force-pushed the bug/tooltip-anchor-mouse-out branch from 6d6a967 to 7aae2ad Compare March 22, 2018 18:05
snide
snide approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. Thanks for making those changes to make it easier to consume. Don't forget to update your changelog / PR title when you merge, since they are now stale.

@cjcenizal cjcenizal changed the title Add inline prop to EuiToolTip. Default to using a div wrapper around the anchor. Fix mouseout logic. Fix EuiToolTip mouseout logic. Mar 22, 2018
@cjcenizal cjcenizal merged commit 670da9f into elastic:master Mar 22, 2018
@cjcenizal cjcenizal deleted the bug/tooltip-anchor-mouse-out branch March 22, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @snide