Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EuiBasicTable cell configuration and EuiTable cell content CSS #565

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Mar 22, 2018

This should address some layout problems on elastic/kibana#17344.

  • EuiBasicTable now supports explicitly setting truncateText and textOnly on column definitions, and supports passing through unrecognized props to the cell (e.g. data-test-subj).
  • Updated CSS so that long single-word cell content will break and wrap mid-word.

image

@cjcenizal cjcenizal force-pushed the bug/table-cell-break-word branch 2 times, most recently from 2d3f8c1 to 7d14afb Compare March 22, 2018 21:31
@cjcenizal cjcenizal requested review from snide and jen-huang March 22, 2018 21:32
@cjcenizal cjcenizal added the bug label Mar 22, 2018
@@ -1,13 +1,16 @@
# [`master`](https://github.com/elastic/eui/tree/master)

- Adjust `EuiCallOut` and dark theme warning coloring ([#563](https://github.com/elastic/eui/pull/563))
- Added a `buttonColor` prop to `EuiConfirmModal` ([#546](https://github.com/elastic/eui/pull/546))
- Added 'baseline' as option to `EuiFlexGroup`'s `alignItems` prop ([#546](https://github.com/elastic/eui/pull/546))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving these.

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! ❤️

…extOnly on column definitions, and support passing through unrecognized props to the cell.

- Update CSS so that long single-word cell content will break and wrap mid-word.
@cjcenizal cjcenizal force-pushed the bug/table-cell-break-word branch from 7d14afb to 71f67ec Compare March 22, 2018 22:24
@cjcenizal cjcenizal merged commit 23f87e5 into elastic:master Mar 22, 2018
@cjcenizal cjcenizal deleted the bug/table-cell-break-word branch March 22, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants