Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint tasks and introduce prettier #576

Merged
merged 3 commits into from
Mar 27, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Mar 27, 2018

Fixes #480. Also fixes a bug introduced by #450. Turns out we haven't had a linter since then -- whoops!

This contains a commit addressing #448, but it's been reverted.

Thanks to @w33ble for all of his help with this.

@cjcenizal cjcenizal changed the title Fix/lint task Fix lint tasks and introduce prettier Mar 27, 2018
@cjcenizal
Copy link
Contributor Author

Note that I've disabled prettier by removing it from the eslint rules config:

  "rules": {
    "no-console": "error"
  }

As you can see by 4a9e6bc, these rules will result in an enormous diff, which will cause significant merge conflicts in the PRs we have open. I've reverted that commit until such a change will be disruptive.

@cjcenizal cjcenizal merged commit 3a7e862 into elastic:master Mar 27, 2018
@cjcenizal cjcenizal deleted the fix/lint-task branch March 27, 2018 02:05
@snide snide mentioned this pull request Apr 30, 2018
44 tasks
@pugnascotia
Copy link
Contributor

We ended up adding Prettier in #1529 (for TypeScript files only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linting rules
3 participants